Is the 'Initial TP' field working properly? Or am I misunderstanding how it's used? It doesn't seem the simulation for DPS takes this into account. My impression is it would use it to help determine average TP for WS, but that doesn't seem to be the case. Is the value used for anything?
If I set initial TP based on average TP return from WS, and then run Optimize TP set with the TP Metric of 'Time to WS', I would think the TP set generated would be one that is fastest to hit the TP threshold defined, while taking into account the Initial TP value.
Instead, it seems the simulation is only taking the Average TP/Round value and calculating that against the TP thresholds. So if you get an Average TP/Round value of 300 from your TP set, and you have a minimum TP threshold of 1000, it'll calculate your average TP for WS at 1200, since 300 + 300 + 300 + 300 = 1200. On average, 4 swings. However, the results are the same, regardless of what value you put in for Initial TP. If you put a value of, say, 100 TP, the simulation still puts you at an average of 1200 instead of ~1000 (100 + 300 + 300 + 300).
All Jobs Damage Simulator And Gear Sets
All Jobs Damage Simulator and Gear Sets
My impression was that initial TP field is only used for "Quicklook TP" and maybe for first round on simulation, but every other round initial TP is calculated from TP return on WS that was simulated, but I haven't look that deep into the code.
Veydal1 said: »
For party buffs / additional buffs, I had the following in mind:
SimonSes said: »
I found a small error with relic hidden proc. Not all relics has ODT with 13% chance. Some of them have 16% for x2.5 and some of them have ODD with 20% chance.
From what I can tell, the ranged relic weapons with Barrage are already handled properly according to BG Wiki. BG Wiki states that the hidden effect on Yoichinoyumi and Annihilator affect the entire Barrage damage. BG Wiki isn't clear on if the hidden damage applies to both hits of Double Shot, but you could argue the wording suggests that only the first hit of Double Shot is affected. I've adjusted the code to only boost the first hit from Double Shot while still boosting all hits from Barrage.
Veydal1 said: »
Is the 'Initial TP' field working properly? Or am I misunderstanding how it's used?
Other changes:
I was pointed to the DRG thread and realized I was not actually using Conserve TP, despite having the DRG and DNC traits and relevant gear stats in place already. I've implemented Conserve TP procs based on the details on the BG Wiki page (x% chance to conserve 10-200 TP randomly after each weapon skill).
I've added a "Verbose DPS" button in the Settings menu at the top of the GUI. Enabling this will print a summary of each attack round and weapon skill used for DPS simulations, including total damage dealt and total TP returned. This should help debugging and clear up any confusion that was mentioned in the DRG thread.
- Verbose DPS output will print multi-attack, daken, zanshin, and kick attack procs, but not print the damage dealt by each hit individually. I could easily add individual auto-attack damage per hit breakdown (to look like a real in-game chat log for example), and probably will later, but I probably wouldn't be able to break down individual multi-attack weapon skill hits the same way.
- Fotia, Conserve TP, and average Regain over time are also printed when they activate. This makes it easy to track TP gained and used throughout the simulation.
I've added a "Verbose Swaps" button in the Settings menu at the top of the GUI. Disabling this will hide the text spam when automatically finding "best" sets, so the code will no longer show the incremental damage improvements for each equipment swap tested.
- Note that printing outputs is slow in general for all programming languages. Enabling the verbose modes may increase runtime of the code by a marginally noticeable amount due to the number of print statements used.
I've fixed an issue where Fotia procs were returning (base_tp + tp_bonus) for DPS simulations.
I've fixed an issue where using Focus with subjob MNK would not provide the bonus stats.
Known issue:
It seems that the Simulations tab equipment selection box has a list size issue. Equipment slots with more than 41 options can not be scrolled to their end to see all available options. For example: DRK has 49 main-hand weapons available, but the scrollbar in the Simulations tab only shows the first 41. I'm not sure why this is, but the workaround for now is to equip the items in the Inputs tab, then use the "Copy to TP/WS set" buttons to move them to the Simulations tab.
Let me know if there are any other issues.
Edit: Link to Github page: https://github.com/IzaKastra/wsdist_beta
[+]
Thx a lot Izanami! :)
Absolute legend. Thanks for all the effort and work you put into this.
I've added a "Very Verbose DPS" button in the Settings menu. This button enables printing a breakdown of every individual attack for attack rounds and weapon skills and highlights crits, missed hits, and fotia/conserveTP procs in color. Naturally, this creates a ton of output text, but it provides much more detail for debugging. "Verbose DPS" is still an option if you only want to see summary values for attack rounds and weapon skills as shown in my previous post.
I needed to slightly adjust how "Double Attack Damage+" and "Triple Attack Damage+" are used in the DPS simulation for the Very Verbose outputs. This wasn't a problem, but it made me question if these stats affect weapon skills. The code currently does not apply these bonuses to weapon skill multi-attacks, but let me know if I should change this.
Other changes:
I needed to slightly adjust how "Double Attack Damage+" and "Triple Attack Damage+" are used in the DPS simulation for the Very Verbose outputs. This wasn't a problem, but it made me question if these stats affect weapon skills. The code currently does not apply these bonuses to weapon skill multi-attacks, but let me know if I should change this.
Other changes:
I've adjusted the Verbose DPS output to print integer damage values, instead of showing 1 decimal place. I think this makes the output easier to read, but it does introduce some "off-by-one" rounding errors in the printed output that you really shouldn't notice anyway on damage dealt. This does not affect any calculations being done.
Endark II and Enlight II now deal magic damage on TP swings based on Enhancing (dark/divine) magic skill. I can't recall if these affect off-hand hits, so I've assumed not for now. Dual-wielding on DRK or PLD is not very common anyway.
I've made it so the one-time bonuses from sneak/trick attack and the various flourishes do not apply during DPS simulations. Previously, the code would apply these bonuses to all weapon skills, which didn't make much sense.
I've updated Oshala's (Prime Staff WS) WSC and FTP values.
[+]
Double and triple attack damage do not apply to weapon skills.
[+]
Is Marin Staff +1 taking into account the Wind Elemental Bonus+11? I'm not seeing that stat when I hover over it?
Edit: I was also doing some testing with Quanpur Necklace and it looks like the 5 Earth affinity isn't doing anything even though I see the stat listed on the item's stats
Edit: I was also doing some testing with Quanpur Necklace and it looks like the 5 Earth affinity isn't doing anything even though I see the stat listed on the item's stats
[+]
Moonlightagb said: »
Is Marin Staff +1 taking into account the Wind Elemental Bonus+11? I'm not seeing that stat when I hover over it?
For now, I've assumed BG Wiki is correct and added "Wind Elemental Bonus +11" to the Marin Staff to add +11% damage (x1.11 multiplier) to Wind element magic.
Moonlightagb said: »
Edit: I was also doing some testing with Quanpur Necklace and it looks like the 5 Earth affinity isn't doing anything even though I see the stat listed on the item's stats
Is Haste Samba buff from DNC applying properly if DNC is selected as the main job? Seems to be working fine if a non-DNC main job is selected.
[+]
Veydal1 said: »
Is Haste Samba buff from DNC applying properly if DNC is selected as the main job? Seems to be working fine if a non-DNC main job is selected.
Looks like I put an if-statement in to not apply "Haste Samba (DNC)" to DNC main job for some reason. I have no idea why I did that.
This issue has been fixed. I guess I'll have to retest everything else I added recently just in case.
Izanami said: »
Veydal1 said: »
Is Haste Samba buff from DNC applying properly if DNC is selected as the main job? Seems to be working fine if a non-DNC main job is selected.
Looks like I put an if-statement in to not apply "Haste Samba (DNC)" to DNC main job for some reason. I have no idea why I did that.
This issue has been fixed. I guess I'll have to retest everything else I added recently just in case.
I think its the same for warcry(war) on war?
[+]
SimonSes said: »
I think its the same for warcry(war) on war?
I switched how I wanted to handle this situation last minute and forgot to remove the old method.
I think Warcry and Haste Samba were the only two "all jobs" buffs to have potency increases for main job.
[+]
Izanami said: »
SimonSes said: »
I think its the same for warcry(war) on war?
I switched how I wanted to handle this situation last minute and forgot to remove the old method.
I think Warcry and Haste Samba were the only two "all jobs" buffs to have potency increases for main job.
Tbh I noticed warcry instantly after your upload, but I just fixed it by adding regular warcry back, when main job is war and completely forgot to pass the info to you (it was very late), so good that Veydal1 wrote about Haste Samba, because that reminded me about warcry.
Izanami said: »
"Blood Rage (WAR)" provides +20% Crit Rate to all jobs. This also provides +20% Ranged Crit Rate to WAR main from job point gifts. I've also corrected an issue where Blood Rage was previously giving WAR main +40% Crit Rate instead of +20% Crit and +20% Ranged Crit.
I'm pretty sure this is 40% crit not ranged crit. The only source I saw that its ranged crit is BG wiki's War job page. In game it just says attacks and on the blood rage bg wiki / jp wiki page both say the job points give 20% crit.
Not sure how the numbers work out, but I use Sroda earring instead of thrud for decimation on BST. 7% double attack just makes more sense to me given its ftp replicating and the boost from nukumi body applies to any damage/all hits (at least in my experience anyhow).
I don't have python installed so if anyone has any feedback, that would appreciated. Probably minor nonetheless, but I am just curious as to Thrud actually "winning" on that posted set.
I don't have python installed so if anyone has any feedback, that would appreciated. Probably minor nonetheless, but I am just curious as to Thrud actually "winning" on that posted set.
Fenrir.Ahlen said: »
I'm pretty sure this is 40% crit not ranged crit. The only source I saw that its ranged crit is BG wiki's War job page. In game it just says attacks and on the blood rage bg wiki / jp wiki page both say the job points give 20% crit.
Shiva.Myamoto said: »
Not sure how the numbers work out, but I use Sroda earring instead of thrud for decimation on BST. 7% double attack just makes more sense to me given its ftp replicating and the boost from nukumi body applies to any damage/all hits (at least in my experience anyhow).
I don't have python installed so if anyone has any feedback, that would appreciated. Probably minor nonetheless, but I am just curious as to Thrud actually "winning" on that posted set.
I don't have python installed so if anyone has any feedback, that would appreciated. Probably minor nonetheless, but I am just curious as to Thrud actually "winning" on that posted set.
The sets on BGWiki are from an older version of the code (but are probably still very good sets). If I run BST/NIN Decimation sets on the most up to date version of the code, I find that:
If I allow all gear to vary, then the Decimation set shows Thrud+Lugra=31322 average damage
If I force one of the earrings to be Sroda, then the Decimation set shows Sroda+Sherida=31198 average damage, essentially zero difference, especially if you consider that the code is probably only accurate to within a few percent.
This is also surprising to me after considering that Decimation is an FTP transferring WS, where multi-attack is usually better than WSD. Decimation is already a 3 (+1 off-hand) hit weapon skill, so an additional hit from a DA, while still a large increase in damage, is not worth as much percentage-wise as a DA on a 1-hit FTP transfer WS. I don't see an issue with Decimation in the code, so I suppose the STR+10 and WSD+3% on Thrud are roughly equivalent to DA+7% on Sroda for Decimation.
Shiva.Myamoto said: »
I don't have python installed
Downloading and running a potentially sketchy executable is generally not recommended, so I've included a GitHub "Action/Workflow" to generate the executable directly on GitHub in a completely transparent way, so you can check that nothing potentially dangerous has gone into it. The executable generated by GitHub is found on the "Actions" page (https://github.com/IzaKastra/wsdist_beta/actions), and the exact code used to generate the executable is also provided for each file version.
[+]
All FFXI content and images © 2002-2024 SQUARE ENIX CO., LTD. FINAL
FANTASY is a registered trademark of Square Enix Co., Ltd.